disasm: fix pltgottargets handling when no matches are found #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this problem on a Debian 10 (buster) system -- because of how Python's string
split
method works, an empty string was being passed topltgotmapper
when no matches were actually found. Obviously this caused problems when trying to split the line and index inside the function.It's possible the same problem may exist elsewhere, e.g., right above when mapping into the
pltsymmapper
function. You might consider also fixing these potential problems.Thanks.